search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Update Salesforce receiver and configuration names in Core #193

Closed dougbu closed 6 years ago

dougbu commented 6 years ago

The Salesforce receiver and configuration names are sfsoap and SalesforceSoap, respectively. This leads to Salesforce URIs of the form https://{host}/api/webhooks/incoming/sfsoap/{id} with an MS_WebHookReceiverSecret_SalesforceSoap application setting or WebHooks:SalesforceSoap:SecretKey:{id} configuration values (for Core).

The Salesforce receiver is inconsistent in two ways:

  1. It is the only receiver with different receiver and configuration names.
  2. It is the only receiver that includes anything beyond the sender name in its names e.g. the GitHub receiver is just named github.

Suggest we use salesforce everywhere. Another option (that I like less) would be salesforceSoap everywhere.

Once we pick a new name (if any), should we update the ASP.NET WebHooks receiver? Next release will be a full release…

dougbu commented 6 years ago

Just update the Core receiver…

dougbu commented 6 years ago

Tracking as a bug just so we don't forget when announcing next release.

dougbu commented 6 years ago

ff7ed820e7