search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Remove double quotes around URLs in NUSPEC metadata #195

Closed Eilon closed 6 years ago

Eilon commented 6 years ago

E.g. here: https://github.com/aspnet/WebHooks/blob/cfb4fe63ae789c602b63bc1f8f6b9a018f044a59/src/Microsoft.AspNet.WebHooks.Receivers.Paypal/Microsoft.AspNet.WebHooks.Receivers.Paypal.nuspec#L13-L15

This causes a problem on the NuGet gallery, which you can see if you click on the links in the description here: https://www.nuget.org/packages/Microsoft.AspNet.WebHooks.Receivers.Paypal/1.2.1

So, we should remove the quotes from around URLs in the NUSPECs of any of the packages here (they aren't really needed).

dougbu commented 6 years ago

@Eilon milestone?

Eilon commented 6 years ago

Need to check if the trailing . that would be at the end of the URL would also cause a problem with the NuGet Gallery. We might want to play it safe and make sure there's a space after each URL to help guarantee that the gallery will parse the URL correctly.

dougbu commented 6 years ago

Moving into Preview1 after a quick chat with @mkArtakMSFT

dougbu commented 6 years ago

f702a66575