search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Add missing variable for structured logging in signature filter #219

Closed twsouthwick closed 6 years ago

twsouthwick commented 6 years ago

The ASP.NET Core logging infrastructure is structured logging, so for each brace-escaped name, a variable must be given. This is in contrast to string.Format style logging where the braces indicate an index. Without this fix, an IndexOutOfRangeException is thrown and the user just sees a 500 error.

dougbu commented 6 years ago

Thanks @twsouthwick. Good catch!