search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Change `SlackCommand.ParseParameters(...)` to not return a `ValueTuple` #231

Closed dougbu closed 6 years ago

dougbu commented 6 years ago

The Microsoft.AspNetCore.WebHooks.Receivers.Slack package currently has a public method that returns a ValueTuple. All consuming applications (including tests) using this method hit dotnet/standard#567 if they target .NET Framework and run on systems with .NET Framework 4.7.1 installed.

Fix is to define a type containing the return values, to use KeyValuePair<TKey, TValue>, or to make one of the return values (likely the string Error) an out parameter.

The other option is to wait for a dotnet/standard#567 fix. But, that's not coming when we expect to ship version 1.0.0-preview1.

dougbu commented 6 years ago

I have a fix for this if we decide to take it in preview1.

dougbu commented 6 years ago

Try to get this into Preview1. That said, it's an issue in a single receiver only on full .NET Framework.

dougbu commented 6 years ago

e65d214c5b