The WebHookRequestReader, SalesforceResultCreator, and *ServiceCollectionSetup classes are currently pub-Internal i.e. in the .Internal namespace but not actually internal. We have no requirements to keep these publicly-accessible because all are used only within their containing assembly or retrieved from DI using truly-public interfaces (IWebHookRequestReader and ISalesforceResultCreator). Should use internal for all of these.
Side note: SalesforceResultCreator has a few virtual methods. That is also not necessary; should remove the modifier.
dougbu
commented
6 years ago
The
WebHookRequestReader,SalesforceResultCreator, and*ServiceCollectionSetupclasses are currently pub-Internal i.e. in the.Internalnamespace but not actuallyinternal. We have no requirements to keep these publicly-accessible because all are used only within their containing assembly or retrieved from DI using truly-publicinterfaces (IWebHookRequestReaderandISalesforceResultCreator). Should useinternalfor all of these.Side note:
SalesforceResultCreatorhas a fewvirtualmethods. That is also not necessary; should remove the modifier.