Closed pranavkm closed 5 years ago
Hello, do you mean that when the key is invalid should it return other message? I would be glad to fix that if you clarify requirements. Thx
@Marusyk no, the intent was to use the term "default id" or something along those lines when the key is the default value. Right now it prints empty quotes, which isn't what the user configures in the log. Consider
[GitHubWebHook]
public IActionResult Blah() {..}
The log message you see in this case is Could not find a valid configuration for the 'github' WebHook receiver, instance ''
. Having ''
instance isn't very intuitive. A more appropriate message might be Could not find a valid configuration for the 'github' WebHook receiver, default instance.
Self-assigning this and two other bugs because we want them done in RC1.
@mkArtakMSFT please add cost: XS
label in this repo. This issue and #247 fit in that bucket. Perhaps #245 too.
This issue was moved to aspnet/AspLabs#46
https://github.com/aspnet/WebHooks/blob/a05a07c420e6316963f41d7bad3fc38e6b74464c/src/Microsoft.AspNetCore.WebHooks.Receivers/Filters/WebHookSecurityFilter.cs#L288-L292
This prints
Could not find a valid configuration for the 'github' WebHook receiver, instance ''
when the key is invalid.