search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Consider improving the log message for incorrectly configured PusherWebHook #247

Closed pranavkm closed 5 years ago

pranavkm commented 6 years ago

Configuring pusher keys is slightly involved (it has two parts) and took me a bunch of tries to figure out. The documentation is detailed, but it would have been way easier if the log spit out exactly the config key it was attempting to look up. Here's what it currently produces:

fail: Microsoft.AspNetCore.WebHooks.Filters.PusherVerifySignatureFilter[0]
      The 'X-Pusher-Key' header value of 'a2cb217b1680b9a18c11' is not recognized as a valid application key. Please ensure the correct application key / secret key pairs have been configured.

Instead, if it said

fail: Microsoft.AspNetCore.WebHooks.Filters.PusherVerifySignatureFilter[0]
      No secret has been configured for configuration key 'WebHooks:Pusher:SecretKey:Default:a2cb217b1680b9a18c11`.

it would have made diagnosing this significantly easier.

mkArtakMSFT commented 6 years ago

@danroth27, I think we should push this out of preview2, as it's not critical.

aspnet-hello commented 5 years ago

This issue was moved to aspnet/AspLabs#45