search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Detect more `[WebHook]` conflicts with other attributes #269

Closed dougbu closed 5 years ago

dougbu commented 6 years ago

Splitting out from #248 (see this comment):

WebHookRoutingProvider doesn't actually throw in all attribute routed cases, only when an attribute route on an action provides a Template. Should check the ControllerModel for an attribute route and check both WebHook actions and containing controllers for an HttpMethodActionConstraint i.e. the result of an applied IActionHttpMethodProvider (see DefaultApplicationModelProvider).

Should probably also check for IConsumesActionConstraints since [Consumes] interferes with WebHookEventNamesConstraints and WebHookVerifyBodyTypeFilters.

Suggest doing this work post-Preview2. Basically about clarifying error messages in problematic cases.

dougbu commented 6 years ago

Clearing the milestone. Need to discuss whether to address #248 or this issue during RC1.

aspnet-hello commented 5 years ago

This issue was moved to aspnet/AspLabs#42