aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Reduce spread of `[GeneralWebHook]` support, stop adding global filters #270

Closed dougbu closed 6 years ago

dougbu commented 6 years ago

nits:

dougbu commented 6 years ago

:up::date:

dougbu commented 6 years ago

I still think that what's going on here with ActionDescriptor.Properties is much much more trouble than it's worth, but I also don't think it's a priority to change

Agree this approach has downsides and that reworking these details shouldn't be a priority. Deciding on then changing to another approach (e.g. merging the IApplicationModelProviders into one and passing context around) would take time better spent elsewhere.

dougbu commented 6 years ago

c9ab0b4ede