Fix gaps in final commit for #258 (c9ab0b4ede) - Githubissues

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs

Apache License 2.0

627 stars 439 forks source link

Fix gaps in final commit for #258 (c9ab0b4ede) #277

Closed dougbu closed 6 years ago

dougbu commented 6 years ago

register DefaultWebHookMetadataProvider in DI
correct names of resources

dougbu commented 6 years ago

This is urgent because it prevents WebHook actions starting cleanly.

dougbu commented 6 years ago

@Eilon plan was to add functional tests of the sample as I work on #180. My concern is the first functional test may take enough time to bump another issue into Ask mode.

On the other hand, I have confirmed the samples now start smoothly.

Thoughts?

dougbu commented 6 years ago

:up::date: to fix other gaps and add first functional tests

dougbu commented 6 years ago

@rynowak I've addressed @Eilon's comments but am not sure he's online…

dougbu commented 6 years ago

This PR addresses #275.

WestDiscGolf commented 6 years ago

The functional tests don't have the right target framework.

dougbu commented 6 years ago

:up::date: rebased

dougbu commented 6 years ago

eecaac30c5