aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Creating webhooks? #309

Closed alexdresko closed 6 years ago

alexdresko commented 6 years ago

The description on https://github.com/aspnet/aspnetwebhooks states:

Libraries to create and consume web hooks on ASP.NET 4.x

Does this project also support creating webhooks?

Suppose I want to allow users configure where to push event information from within my application. For example, when a new user is created in my application, a user might configure the system to push that data to IFTT or Zapier.

Is this the kind of utility library I need, or do I need to roll my own? I never got a chance to do too much with https://github.com/aspnet/aspnetwebhooks, but it seems like that was supported.

alexdresko commented 6 years ago

That moment when you created an issue because you couldn't find anything after searching for a while, but immediately find what you're looking for after you submit the new issue.

Flesh out ASP.NET Core sender packages · Issue #183 · aspnet/WebHooks https://github.com/aspnet/WebHooks/issues/183

Sending WebHooks · Issue #293 · aspnet/WebHooks https://github.com/aspnet/WebHooks/issues/293

Migrate WebHooks sender package to ASP.NET Core by Havret · Pull Request #301 · aspnet/WebHooks https://github.com/aspnet/WebHooks/pull/301

ericbrunner commented 6 years ago

@alexdresko I search for Webhook Sender sample code, too. Did you get some help or have progress with that?

alexdresko commented 6 years ago

I did not. I'm going to roll my own for now. Current plan to is to have one table containing all of the event types my application supports, and another table (1:M) containing subscribers to those events. The subscribers table will just contain the URL where the event will push some JSON about the event. I found that Zapier can handle just about any JSON you throw at it, and you can route that data to any of their supported services.

If IFTTT supports a generic JSON receiver like Zapier does, I couldn't find it.

ericbrunner commented 6 years ago

Hi @alexdresko , Thanks for your detailed reply. I guess they are a bit busy with the WebHook Sender part

davesmits commented 6 years ago

I got a sample here: https://github.com/davesmits/WebHooks/tree/feature/custom ; I ported the .net framework sender packages and using the .net core standard receiver

alexdresko commented 6 years ago

@davesmits Since you have some experience with this, can you explain the difference between my custom solution here and what the webhook framework does? It's not well documented, and I'm concerned that my custom solution isn't suitable longterm.

davesmits commented 6 years ago

well webhooks provide a api to register / unregister webhooks. retry of the calls + handling http responses in a right way let the authenticated user register webhooks and able to send webhooks to the right users echo verification when registering a webhook filter mechanism for event types

dougbu commented 6 years ago

There are two WebHooks repos we manage: https://github.com/aspnet/WebHooks (this one) is about receiving WebHooks in ASP.NET Core applications. https://github.com/aspnet/AspNetWebHooks is about sending or receiving WebHooks in ASP.NET (i.e. .NET Framework) applications.

ericbrunner commented 6 years ago

@dougbu Thanks for clarification. Is there a plan for custom Webhook sender in Asp.Net Core? The custom Webhook sender from Asp.Net can't be used in an Asp.Net Core 2.x App.

dougbu commented 6 years ago

We have an issue on the Backlog (#183) covering porting the older Sender code but no immediate plans to work on it. In fact, we have enough conflicting requirements that we closed a PR (#301) rather than review it or even to choose an overall design.

You may want to start with #301 or see if there's a fork out there somewhere.

Closing because this is a duplicate of #183. Please continue this discussion (if needed) there.