Enforce mandatory properties in Azure Alert payload

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs

Apache License 2.0

627 stars 439 forks source link

Enforce mandatory properties in Azure Alert payload #46

Closed maitre-matt closed 8 years ago

maitre-matt commented 8 years ago

Tag mandatory properties with Required.Always so JSON.NET enforces the requirement during (de)serialization
Fix a couple of comment typos on KuduNotification
Add required 'resourceRegion' property to AlertMessage1.json test content
Add AlertMessage3.json to validate change against sample payload in Azure docs
Add unit tests

dnfclas commented 8 years ago

Hi @maitre-matt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

dnfclas commented 8 years ago

@maitre-matt, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

HenrikFrystykNielsen commented 8 years ago

Committed to dev: 6958689c68e6ed1772892ffb19a2558af1721c45 Thanks! Henrik