search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Unhandled exceptions in webhook handlers are not passed to IExceptionLogger #61

Closed georgiosd closed 8 years ago

georgiosd commented 8 years ago

Hi,

In normal Web API services, unhandled exceptions can be handled by registering an IExceptionLogger. However, this is not the case with webhook handlers - the exception seems to be swallowed.

If hope this is a bug and not a feature! :)

HenrikFrystykNielsen commented 8 years ago

Interesting point -- at the moment, the exception is caught in the receiver controller -- it's the very last piece of WebHookReceiversController.

I presume we can just let that bubble up instead.

georgiosd commented 8 years ago

Yes i think that would be best! On Sat, 21 May 2016 at 17:48, Henrik Frystyk Nielsen < notifications@github.com> wrote:

Interesting point -- at the moment, the exception is caught in the receiver controller -- it's the very last piece of WebHookReceiversController https://github.com/aspnet/WebHooks/blob/master/src/Microsoft.AspNet.WebHooks.Receivers/Controllers/WebHookReceiversController.cs .

I presume we can just let that bubble up instead.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aspnet/WebHooks/issues/61#issuecomment-220781661

HenrikFrystykNielsen commented 8 years ago

ok, check this out: 2bc1d844a41e5ff353a9e4c9888ad936f572086e

georgiosd commented 8 years ago

Thank you sir :) When can this go out to nuget? On Sun, 22 May 2016 at 23:17, Henrik Frystyk Nielsen < notifications@github.com> wrote:

ok, check this out: 2bc1d84 https://github.com/aspnet/WebHooks/commit/2bc1d844a41e5ff353a9e4c9888ad936f572086e

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aspnet/WebHooks/issues/61#issuecomment-220853690

HenrikFrystykNielsen commented 8 years ago

@georgiosd -- it's out -- look for rc1c :)

georgiosd commented 8 years ago

Thank you very much :)

On Wed, Jun 1, 2016 at 11:36 AM Henrik Frystyk Nielsen < notifications@github.com> wrote:

@georgiosd https://github.com/georgiosd -- it's out -- look for rc1c :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aspnet/WebHooks/issues/61#issuecomment-222894242, or mute the thread https://github.com/notifications/unsubscribe/ABmDdsKpEj8ShYlJEFjQwPrGaDmuJVVvks5qHRRigaJpZM4IiEM3 .