aspnet / aspnet-docker

[Archived] ASP.NET Core Docker images for 1.x. Go to https://github.com/dotnet/dotnet-docker for 2.1 and up.
https://asp.net
719 stars 171 forks source link

Stop producing full-qualified nanoserver tags #313

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

See https://github.com/dotnet/dotnet-docker/issues/312. These were undocumented anyways, and increased our maintenance work. Patches to nano should now automatically roll up from microsoft/dotnet into the aspnetcore images.

cc @ravimeda

MichaelSimons commented 7 years ago

@natemcmaster - microsoft/dotnet is still producing the full version tags such as microsoft/dotnet:2.0.0-runtime-nanoserver-10.0.14393.1715. The tags that are being dropped at the partial version tags - microsoft/dotnet:2.0-runtime-nanoserver-10.0.14393.1715, microsoft/dotnet:2-runtime-nanoserver-10.0.14393.1715, etc. I think the full version tags should be maintained for the time being.

natemcmaster commented 7 years ago

Ah, I missed that subtle distinction. The aspnetcore images don't have a mix of NanoServer version and less-than fullyqualified tag, so this change isn't necessary.

MichaelSimons commented 7 years ago

I missed it too until I saw your PR - sorry about that.