Closed jbogard closed 6 years ago
So, just wanted to let you know we saw this and are discussing it. I don't have a decision yet, but here is some of my thinking:
My initial reaction was to close this. We don't want to depend on PowerShell. It adds to our servicing/patching burden, adds bloat some users don't need, and powershell.exe isn't something we can install anyways. Personally, I would want powershell in my images too though, so I started looking into how hard it is to install pwsh.exe (Powershell 6) on your own. It's a pain because there is no way to download/unzip from nanoserver-1709, so you have to use windowservercore in a multi-stage build. But, I'm optimistic this will be less of a problem soon: https://blogs.technet.microsoft.com/virtualization/2017/12/19/tar-and-curl-come-to-windows/.
Anyways, we're still discussing and considering the tradeoffs here.
Ah, yes Powershell 6 would make more sense. Thanks for the update!
And yes, I went down the path of building my own image with pwsh.exe and it’s not super easy.
On Fri, Feb 16, 2018 at 11:56 AM Nate McMaster notifications@github.com wrote:
So, just wanted to let you know we saw this and are discussing it. I don't have a decision yet, but here is some of my thinking:
My initial reaction was to close this. We don't want to depend on PowerShell. It adds to our servicing/patching burden, adds bloat some users don't need, and powershell.exe isn't something we can install anyways. Personally, I would want powershell in my images too though, so I started looking into how hard it is to install pwsh.exe (Powershell 6) on your own. It's a pain because there is no way to download/unzip from nanoserver-1709, so you have to use windowservercore in a multi-stage build. But, I'm optimistic this will be less of a problem soon: https://blogs.technet.microsoft.com/virtualization/2017/12/19/tar-and-curl-come-to-windows/ .
Anyways, we're still discussing and considering the tradeoffs here.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aspnet/aspnet-docker/issues/362#issuecomment-366310134, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGYMl4xvqd8LJddgOg3hV8wAWgTsVkJks5tVcEvgaJpZM4R848O .
Hey @jbogard, I'm going to close this as this isn't something we plan to add to the aspnetcore images. In fact, we don't plan on providing any new microsoft/aspnetcore-build
images in the near future. We are merging it with the microsoft/dotnet:sdk
images. See https://github.com/aspnet/Announcements/issues/298.
If you would still like this, you can open this request on https://github.com/dotnet/dotnet-docker.
Thanks! In any case pwsh.exe would make more sense.
On Mon, Apr 2, 2018 at 5:54 PM Nate McMaster notifications@github.com wrote:
Closed #362 https://github.com/aspnet/aspnet-docker/issues/362.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aspnet/aspnet-docker/issues/362#event-1552908583, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGYMuJNjHG09H8-KImLeUpbMXsnRefXks5tkqwygaJpZM4R848O .
FYI - there is already an issue tracking this for the microsoft/dotnet images - https://github.com/dotnet/dotnet-docker/issues/360
or I install Powershell as part of my container build
Any guidance on How I should go about doing this under microsoft/dotnet:2.0-sdk-nanoserver-1709
image?
@tugberkugurlu - You can follow what is done in the Dockerfile used to produce the microsoft/powershell images.
Steps to reproduce the issue
(e.g. copy your Dockerfile or docker-compose.yml file here) The 1709-based build images don't have powershell installed, which means I can't run my build inside of the build images:
Then inside the build image:
Nanoserver starting with 1709 no longer includes Powershell, which makes sense, but I'm now strictly limited to cmd-based builds inside my build container (or I install Powershell as part of my container build).
Expected behavior
Powershell to be there like it is in the
sac2016
images. You could use themicrosoft/powershell:nanoserver
images as the base instead of just plainnanoserver
ones.Actual behavior
It is not.