Consider not shipping NodeJS in aspnetcore-build 2.1

natemcmaster commented 6 years ago

Currently, the 2.1 nightly images of aspnetcore-build have NodeJS 8 in them. However, we should investigate the impact of removing NodeJS altogether and instead instructing users to use multi-stage build.

Benefits:

Pay for play. Not everyone needs NodeJS
Multi-stage is composable. Users can select the version of NodeJS to match their project. Historically, we've picked a version of NodeJS, but it can be hard to upgrade once we release an image...leading to stale versions of node. #334 #182 #345

Downsides:

Increase complexity. It requires additional setup in a dockerfile that may be non-obvious to new users
MSBuild -> Node. It means you can't invoke NodeJS from MSBuild. Our SPA templates currently invoke webpack from an MSBuild target.
Breaking change. Users using the latest or 2.1 tags would be broken by removing NodeJS

muratg commented 6 years ago

We can probably avoid the breaking change by using the multi-stage build, final stage with the current name and NodeJS.

Also, I believe we're not releasing SPA templates anymore so that shouldn't be an issue.

@glennc thoughts?

natemcmaster commented 6 years ago

Closing as we are not planning to ship aspnetcore-build 2.1 at all. See https://github.com/aspnet/Announcements/issues/298.

aspnet / aspnet-docker

Consider not shipping NodeJS in aspnetcore-build 2.1 #367