search

aspnet / aspnet-docker

[Archived] ASP.NET Core Docker images for 1.x. Go to https://github.com/dotnet/dotnet-docker for 2.1 and up.
https://asp.net
719 stars 171 forks source link

Add missing space to checksum string #441

Closed gldraphael closed 5 years ago

gldraphael commented 5 years ago
  1. Added the missing space to the checksum string for the check to pass.
  2. Add w flag to sha256sum so that user is warned if a formatting issue (like the missing space) occurs again in the future.
natemcmaster commented 5 years ago

Thanks for the PR. I don't see a description of the problem you're solving. I ran the original instructions and don't see a problem, even when I added --warn to sha256sum. Can you explain what problem you encountered? I'd like to validate that these changes work before merging.

natemcmaster commented 5 years ago
Screen Shot 2019-05-29 at 3 36 17 PM
gldraphael commented 5 years ago

Hey Nate, neither can I reproduce this anymore nor find the failing builds from build history (they've been deleted). I'm guessing the base images have been updated upstream to use a newer sha256sum that's more forgiving of the spaces -- which if true is a good thing IMO.

(I picked the checksum with the additional space from the nodejs website.)

natemcmaster commented 5 years ago

Ok. This is just sample code. I suppose someone out there might have an older version of sha256sum, so I'll merge this. Thanks for the contribution!