search

aspnet / dnvm

OBSOLETE - see readme
Other
174 stars 61 forks source link

Set machine-wide DNX_HOME in dnvm-setup. #473

Closed cesarblum closed 8 years ago

cesarblum commented 8 years ago

Set machine-wide DNX_HOME environment variable when running dnvm setup on Windows in elevated mode.

439

dnfclas commented 8 years ago

Hi @cesarbs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

cesarblum commented 8 years ago

@anurse @glennc @muratg

cesarblum commented 8 years ago

I tried adding unit tests, but I couldn't find a clean way to mock Is-Elevated and setting a machine environment variable.

analogrelay commented 8 years ago

@dougbu @cesarbs and I chatted and we think there are some bigger issues. I'm going to summarize that discussion over on the issue (#439) but we can probably close this PR for now.

cesarblum commented 8 years ago

Closing PR until we get a better design on this.