Update dnvm.sh - Githubissues

aspnet / dnvm

OBSOLETE - see readme

Other

174 stars 61 forks source link

Update dnvm.sh #504

Closed RussellTaylor83 closed 8 years ago

RussellTaylor83 commented 8 years ago

This should give a more accurate name, particularly when a bad name is specified. I believe this will be less confusing.

Previously:

dnvm alias default badname
dnx-mono.badname is not an installed DNX version

Now:

dnvm alias default badname
badname is not an installed DNX version

This is more obvious if you did:

dnvm alias default 1.0.0-rc1-update1
dnx-mono.1.0.0-rc1-update1 is not an installed DNX version

This confused me into thinking it was looking for a mono version.

dnfclas commented 8 years ago

Hi @RussellTaylor83, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

RussellTaylor83 commented 8 years ago

Need to run this against the automated tests, and see if the tests need updating.

BrennanConroy commented 8 years ago

FYI see the comment in https://github.com/aspnet/dnvm/pull/478

RussellTaylor83 commented 8 years ago

Thank you Brennan! You've saved me a lot of time.