Closed mkArtakMSFT closed 2 years ago
@Pilchie do you think that my assessment here for bumping up to v4.0 is reasonable? Essentially, my point is that because we have changed the license, let's bump up the major version.
Bumping to 4.0.0 seems reasonable to me. @ChrisSfanos - any thoughts?
I'm good with moving to 4.0.0
Thanks everyone!
The only way I found for resolving npm audit warnings was by forcing the usage of the latest version of the
gulp-parent
dependency.For that I've used a new
override
support in Node v8: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overridesHere is the output from
npm audit
after the change:I've also updated the license header of the jquery-validation-unobtrusive.js file so that it is aligned with our current (MIT) license as well as is written in JSDoc style, as that's what the new gulp-uglify dependency requires. Otherwise, the license comments will be stripped out from the generated
.min.js
file.Keeping this as
draft
for now to validate the fix before actually proceeding with merging, given that I've updated the dependencies to their latest versions.Validation Did some basic validation and it works: