search

aspnet / libuv-build

Libuv build automation for ASP.NET Core
Other
22 stars 18 forks source link

Update libuv to v1.9.0 #11

Closed halter73 closed 8 years ago

halter73 commented 8 years ago

https://github.com/dotnet/coreclr/issues/1466

@moozzyk

dnfclas commented 8 years ago

Hi @halter73, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

moozzyk commented 8 years ago

:ship: :it:

halter73 commented 8 years ago

The new compiler flags do add more shared library dependencies so it's a little scary.

Before:

~/libuv-build$ ldd artifacts/build/package-src-linux/contents/runtimes/rhel-x64/native/libuv.so
        linux-vdso.so.1 =>  (0x00007ffea956d000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f71c78d1000)
        /lib64/ld-linux-x86-64.so.2 (0x0000558ef6d13000)

After:

~/libuv-build$ ldd artifacts/build/package-src-linux/contents/runtimes/rhel-x64/native/libuv.so
        linux-vdso.so.1 =>  (0x00007ffd73ffa000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ff33513e000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ff334f3a000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ff334d31000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ff334b13000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ff33474e000)
        /lib64/ld-linux-x86-64.so.2 (0x0000559eea2d1000)
halter73 commented 8 years ago

Here is the output for dotnet cli:

~/$ cat .dotnet/share/dotnet/cli/.version
5b0afe7880bde1b4aa8d4e0b31400efb2da07db0
1.0.0.001718
~/$ ldd .dotnet/share/dotnet/cli/bin/dotnet
        linux-vdso.so.1 =>  (0x00007ffd408ba000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f80f7fc0000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f80f7da2000)
        libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f80f7a9d000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f80f7797000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f80f7581000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f80f71bb000)
        /lib64/ld-linux-x86-64.so.2 (0x000055ff6bef7000)

I'm guessing that have different binaries for different distros though... We are going to have to retest the libuv binary on all of our supported distros again.

@davidfowl Is there someone we should talk to about whether or not we should dynamically link these libraries?