search

aspnet / libuv-build

Libuv build automation for ASP.NET Core
Other
22 stars 18 forks source link

Write the commit file #12

Closed pranavkm closed 8 years ago

moozzyk commented 8 years ago

What does this do (or maybe why is it needed)?

pranavkm commented 8 years ago

It's writing the commit hash to the artifacts dir. The CI build expects to see the file there

pranavkm commented 8 years ago

It's from https://github.com/aspnet/KoreBuild/blob/dev/build/shade/_k-standard-goals.shade#L98, but because you overwrite the target, the file doesn't get written out.

moozzyk commented 8 years ago

Isn't it just to add an attribute to the assembly? The thing is that there are no assemblies here so it seems weird and unneeded.

pranavkm commented 8 years ago

Well the idea is to be able to tell what set of commits a build came from.

muratg commented 8 years ago

:shipit:

halter73 commented 8 years ago

This isn't part of Universe anymore. No need to merge https://github.com/aspnet/Universe/commit/8667e2496b1441d7f6308fec85af3cf78788954b

pranavkm commented 8 years ago

No longer needed