aspnet / libuv-build

Libuv build automation for ASP.NET Core
Other
22 stars 18 forks source link

Build LibUV for Linux-x64 #20

Closed gkhanna79 closed 7 years ago

gkhanna79 commented 7 years ago

We now build a distro-agnostic version of .NET Core SharedFX for Linux (glibc based) platforms. For this, we need to do the following:

1) Investigate if libuv has any platform specific dependencies and if so, fix them to be dynamically computed and invoked. Please work with @janvorli on this.

2) Publish LibUV for Linux-X64 RID.

CC @davidfowl @janvorli

moozzyk commented 7 years ago

We build libuv only once and copy the same binary for different RIDs so I think 1) is resolved.

@gkhanna79 - With regards to 2) - once we create a version for linux-x64 should we remove the distro specific versions from the package?

gkhanna79 commented 7 years ago

Does that mean it only has dependency on glibc?

We should plan to remove it over time, once the build is tested and deemed solid. For now, keep the build as is.

Thanks, Gaurav

-------- Original message -------- From: Pawel Kadluczka notifications@github.com Date: 12/29/16 9:42 AM (GMT-08:00) To: aspnet/libuv-build libuv-build@noreply.github.com Cc: "Gaurav Khanna (CLR)" Gaurav.Khanna@microsoft.com, Mention mention@noreply.github.com Subject: Re: [aspnet/libuv-build] Build LibUV for Linux-x64 (#20)

We build libuv only once and copy the same binary for different RIDs so I think 1) is resolved.

@gkhanna79https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgkhanna79&data=02%7C01%7CGaurav.Khanna%40microsoft.com%7Cff42636def6045fcc9ce08d430120bff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636186301444264579&sdata=Mjr1f7ALeKOxf5%2FPnYnuhm98OW16TuFdNe1EB0%2FAt08%3D&reserved=0 - With regards to 2) - once we create a version for linux-x64 should we remove the distro specific versions from the package?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2Flibuv-build%2Fissues%2F20%23issuecomment-269665699&data=02%7C01%7CGaurav.Khanna%40microsoft.com%7Cff42636def6045fcc9ce08d430120bff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636186301444274588&sdata=tacrVfhO9QsdUfSeeDp44F%2B8%2FR2MZSSfp%2BVx8U2XX%2Fk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJA3wbN63iIzlaktgWdMt2XkiceEPTu_ks5rM_D8gaJpZM4LXrQQ&data=02%7C01%7CGaurav.Khanna%40microsoft.com%7Cff42636def6045fcc9ce08d430120bff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636186301444274588&sdata=UA51aSdy1gtQkLDYHamM3xGwcjhX%2BsMgSBX7%2FViDLCI%3D&reserved=0.

moozzyk commented 7 years ago

Here is the exact list of dependencies libuv has:

 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [librt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
gkhanna79 commented 7 years ago

Happy New Year to all :)

These seems to be basic enough dependencies that should not vary with each distro. @janvorli What are your thoughts?

@moozzyk Once you have the libuv package for Linux-x64 published to dotnet-core feed on myget, please update https://github.com/dotnet/core-setup/blob/master/pkg/projects/Microsoft.NETCore.App/project.json#L43 to reflect the new package.

janvorli commented 7 years ago

@gkhanna79, right, there is nothing distro dependent. I've also checked the versions of the symbols from glibc and the highest version used is 2.14, so it doesn't reference anything recent.

gkhanna79 commented 7 years ago

@moozzyk do you have the package published to myget for linux-x64 libuv?

moozzyk commented 7 years ago

Almost there. There were some issues with myget earlier.

moozzyk commented 7 years ago

Fixed via https://github.com/aspnet/libuv-build/commit/d2e826e16efb3639d4512f5ebc1ba81b3899c5d1 and https://github.com/aspnet/libuv-package/commit/1646ae60d177b5fb58197899e1d1a976ded8cb95