search

aspnet / libuv-build

Libuv build automation for ASP.NET Core
Other
22 stars 20 forks source link

Build libuv with VS2017 #29

Open BrennanConroy opened 7 years ago

BrennanConroy commented 7 years ago

BinSkim complains about some stack protectors when using VS2015 Update 2, its been fixed in VS2015 Update 3 or even better just use VS2017.

moozzyk commented 7 years ago

Building with VS2015 Update 2 is probably just a matter of updating VS on the agent(s). Building with VS2017 may require updating team city to be able to use latest MSBuild or changing MSBuild steps to cmd steps.

muratg commented 6 years ago

@natemcmaster do you think this will be a requirement with the new product build plans?

natemcmaster commented 6 years ago

Yes.

natemcmaster commented 6 years ago

Also, consider using cmake. The CoreCLR team uses this to build native code so it will be available in our product-build toolsets.

muratg commented 6 years ago

OK, assigning to @ryanbrandenburg, he can take a look when he's back. 🎁

cc @Eilon

moozzyk commented 6 years ago

I like the idea of using libuv's build system but I am not sure how feasible it is. I don't think they support building for windows arm (not sure about Linux). They also do not use CMake but gyp/autotools.