Add sanitize and optimizations to Unix builds

aspnet / libuv-build

Libuv build automation for ASP.NET Core

Other

22 stars 18 forks source link

Add sanitize and optimizations to Unix builds #30

Closed BrennanConroy closed 7 years ago

BrennanConroy commented 7 years ago

Added fsanitize=address to both Darwin and Linux builds, and noticed they both didn't run with optimizations so turned on -O3

dnfclas commented 7 years ago

@BrennanConroy, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

BrennanConroy commented 7 years ago

Something to note, the sanitize almost doubles the .so and .dylib size :/

moozzyk commented 7 years ago

Current flags mimic how libuv is built using gyp/autotools in the libuv repo. I have two concerns:

why aren't they using these flags
we may not be able to preserve these flags when we move to using libuv build (if we decide to do this)