search

aspnet / libuv-package

NuGet packages for libuv
Other
19 stars 14 forks source link

Deprecate this repository #17

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

To simplify the build setup, we can put both the compile and packaging build steps into one repository.

We will still use separate build configurations on TeamCity to compile for osx/windows/linux etc, but keeping the build code in separate repositories isn't necessary.

Code moved here: https://github.com/aspnet/libuv-build/pull/26

dnfclas commented 7 years ago

@natemcmaster, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

Eilon commented 7 years ago

Is this change necessary? What is motivating it?

natemcmaster commented 7 years ago

Motivated by converting sake to msbuild. We want to simplify how libuv builds, and part of that means we don't need two repos to build and package this library.

natemcmaster commented 7 years ago

Can we just keep 2 repos

Still in favor of one repo. Two repos is overengineering. If we keep two, when I finish conversion to MSBuild, the only thing this repo would contain is a nuspec file and few dozen lines of powershell that call "nuget.exe pack". (Plus license.txt which is undeletable of course).

moozzyk commented 7 years ago

You could leave just a license in this repo and move everything else, no?

natemcmaster commented 7 years ago

Talked with @Eilon. We'll reverse the direction of the PRs. Move content here from libuv-build.