search

aspnet / libuv-package

NuGet packages for libuv
Other
19 stars 14 forks source link

Update the libuv used by Kestrel to one that has ControlGuard enabled #25

Closed Eilon closed 6 years ago

Eilon commented 6 years ago

Description

The Kestrel package currently uses a version of the libuv package that was built without ControlGuard enabled. A newer version of the libuv package exists, but is not yet referenced by Kestrel.

Customer Impact

Customers wishing to use only libraries that have all the best practice compiler features enabled cannot use this library. We were contacted by Microsoft partner teams that they wish to use this.

Regression from?

Not a regression.

Risk

Very Low. Just need to use a newer version of the library that has this compiler feature enabled.

Eilon commented 6 years ago

Tagging @blowdart and @BethMantey.

blowdart commented 6 years ago

Needs performance testing to please Fowler, as this may end up slower.

Eilon commented 6 years ago

Handled this in an email with an alternative approach, so closing this issue.