search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

Styles & Scripts break in the Development #102

Closed hishamco closed 4 years ago

hishamco commented 7 years ago

@DamianEdwards is this by design, the expectation is the application run in all the environments without adding extra files to the project Please let me know if I can push my PR to fix this

DamianEdwards commented 7 years ago

You'll need to give me more detail. Works OK for me.

hishamco commented 7 years ago

Perhaps you already have them but you forget to commit them in the early days, please have a look to this: https://github.com/aspnet/live.asp.net/blob/dev/src/live.asp.net/Views/Shared/_Layout.cshtml#L13 https://github.com/aspnet/live.asp.net/blob/dev/src/live.asp.net/Views/Shared/_ValidationScripts.cshtml#L2

those just few examples for non exist resources which is needed in the Development environment

DamianEdwards commented 7 years ago

The project is set up such that you need to run gulp at least once for those things to be copied. The lib folder is not committed at all. Originally it was configured to run npm & bower restore during dotnet restore via the "scripts" hook in project.json, but that added a bunch of time to dev scenarios that I didn't like. It also made the deployment time to Azure longer, as it then does it during both build and publish needlessly.

I can revisit this to see if there's a middle ground that produces something I'm happy with, but it's not high on my priority list right now.

hishamco commented 7 years ago

My aim was to create a PR to add those files instead of run npm & bower, so the deployment will not take that time in this case furthermore it will be used in Development phase.