search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

Use IFileProvider #113

Closed hishamco closed 7 years ago

hishamco commented 7 years ago

@DamianEdwards I notice that you are using File class in DeploymentService, I change it using the new ASP.NET FileSystem, so there 're a lot of benifits one of them async support. If this fine with you I will submit my changes

DamianEdwards commented 7 years ago

The call site is a property anyway, so no benefit from async. Plus, the file providers use the same APIs under the covers, and you'd have to initialize your own instance as the one provided for ContentRoot is rooted there and you can't traverse out of it, which I need to in order to get the Kudu active deployment file.

I don't think it adds anything in this case.