Added a calendar notification 10 minutes before the standup begins

[dnfclas]

Hi @khellang, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[DamianEdwards]

This seems to have some issues. I tried it now in staging and when I open the downloaded ICS in Outlook it sets the reminder to 306 days.

[khellang]

Hmm. It worked perfectly for me here. This is imported from staging:

Maybe it's an Outlook-specific thing?

[DamianEdwards]

I've deployed a change to staging, can you confirm that it still works for you?

[khellang]

Hmm. The older RFC (2445) says

Example: A trigger set 15 minutes prior to the start of the event or to-do.

TRIGGER:-P15M

But the newer RFC (5545) says

Example: A trigger set 15 minutes prior to the start of the event or to-do.

TRIGGER:-PT15M

See the extra T there? That might have something to do with it.

While you're in there changing stuff, you might also want to look at some of the newer properties (RFC 7986) to the iCal format, like URL, etc.

[alexwiese]

306 days is ~10 months not minutes. I think it should have a preceding T to specify time duration not date. Eg. -PT10M

[khellang]

Looks like it's now 15 minutes after start:

[DamianEdwards]

Doh, let me add the minus sign back

[DamianEdwards]

Try again?

[khellang]

Works now 👍

[DamianEdwards]

Awesome, thanks