search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

React to remove GC trigger for cache eviction #128

Closed hishamco closed 7 years ago

hishamco commented 7 years ago

I think we should remove the CompactOnMemoryPressure from AddCachedWebRoot, after the commit https://github.com/aspnet/Caching/commit/f44517ef0eb6ca7833dbdc7f3aa3cb3832c434be

/cc @JunTaoLuo @DamianEdwards

JunTaoLuo commented 7 years ago

This isn't currently needed since the repo uses FTS (1.1) dependencies. Once it updates to 2.0 packages, we'll need to react to more than just this breaking change.

hishamco commented 7 years ago

@DamianEdwards can we upgrade to 1.2.0-* if it's possible, because I'm working on other hand to use our new TagHelperComponent to simplify some scenarios in the current code

I'm not sure if the upgrade will help to fix this issue too

DamianEdwards commented 7 years ago

Like I said in other PR, I don't update this site until an official preview release.