search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

Remove YouTube black borders #138

Closed hishamco closed 4 years ago

hishamco commented 7 years ago

The black borders in the YouTube thumbnails is ugly little, I did some experiment to make the thumbnails like this: capture

If the change looks fine with you, I will make a PR for this

aafvstam commented 6 years ago

The YouTube API only returns the thumbnails with black overflow areas. There is no option to get them returned in white background. Only option would be to crop the returned image to the actual thumbnail size without the borders.

hishamco commented 6 years ago

Nope, medium quality images come without black borders, IMHO this issue can be solved either by cropping as you mentioned before or using some CSS to rid off the black border

aafvstam commented 6 years ago

Quote: "The image is not cropped, but may include black bars so that the size is correct." https://developers.google.com/youtube/v3/docs/thumbnails

aafvstam commented 6 years ago

Just tested, the mediom indeed gives no black borders despite what the documentation mentioned. Gave me some other layout issues though resulting in one black border on the right :-)