search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

Add semantic importance and meaning to show badges/labels #39

Closed peterblazejewicz closed 9 years ago

peterblazejewicz commented 9 years ago

This commits adds HTML5 semantics to show StandBy/OnAir badges. They will be now differently rendered or spoken - as intended by visual clues.

There is no visual change in how visual clues are rendered by BS CSS, as strong tag has the same weight in BS css as label class. The change will be seen in other readers or heard in readers:

20150809222127 20150809221833 20150809222259

Thanks!

dnfclas commented 9 years ago

Hi @peterblazejewicz, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

hishamco commented 9 years ago

Looks good :smile:

DamianEdwards commented 9 years ago

That looks bolder to my eye without actually checking it yet. I'll try it and check for myself in a few browsers before merging.

hishamco commented 9 years ago

You are right @DamianEdwards it's bolder, needs some UI improvements

peterblazejewicz commented 9 years ago

Guys, I do know what I'm doing: https://github.com/twbs/bootstrap/blob/master/less/labels.less#L9 https://github.com/twbs/bootstrap/blob/master/less/normalize.less#L120 20150810214820 20150810215310 Unless you're using local stylesheet you should always get normalized bold weight. Thanks!

hishamco commented 9 years ago

@peterblazejewicz I know what you did. Seems the font is bolder, perhaps @DamianEdwards doesn't notice that before in ON AIR, but it's obvious in STANDBY

dnfclas commented 9 years ago

@peterblazejewicz, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

DamianEdwards commented 9 years ago

OK I think I know what's happening here. @peterblazejewicz is doing this work on a Mac and thus he's seeing different fonts to us. Am I correct? The font we use on Windows (Segoe UI Light) has very mild bolding, so your screenshots (which use Helvetica I'm guessing) make the bold look much more pronounced.

peterblazejewicz commented 9 years ago

@DamianEdwards Yes, I'm working exclusively on Mac for ASP.NET 5 :D Thanks folks!