search

aspnet / live.asp.net

Code for live.asp.net, which hosts the ASP.NET Community Stand-up
https://live.asp.net/
MIT License
289 stars 114 forks source link

Low Google PageSpeed Insights score #50

Closed cgrantnz closed 4 years ago

cgrantnz commented 9 years ago

Currently the live site gets 72/100 for desktop and 52/100 for mobile https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Flive.asp.net%2F&tab=mobile I showed the site to a Ruby dev friend and he wasn't kind about that pagespeed score... If I submit a PR that bumps it up without doing anything weird will you take a look at it?

Image of PageSpeed Insights score

hishamco commented 9 years ago

Thanks @callumelgrant, let us know the fixes that may improve the speed, also I will check it too using using Web Developer Checklist

hishamco commented 9 years ago

BTW @callumelgrant can you check staging environment https://asp-standup-staging.azurewebsites.net/ because the recent PRs doesn't reflect immediately until it's stable

hishamco commented 9 years ago

The staging got 79/100, @callumelgrant be freely to submit a PR if it improves the source :smile:

DamianEdwards commented 9 years ago

I took a look. Seems we could do the following to improve the score:

The other items we're scored lower on are out of our control really (like the ms.js file). I don't really want to defer loading of the bootstrap CSS because that'll result in a potential FOUC.

hishamco commented 9 years ago

:+1:

hishamco commented 9 years ago

@DamianEdwards regarding the second point I prefer to create StyleInlineTagHelper because the name ScriptInliningTagHelper doesn't make sense to support both inline script and style

DamianEdwards commented 9 years ago

@hishamco just change the name of the class, e.g. ScriptStyleInliningTagHelper

hishamco commented 9 years ago

Sound looks good :smile: