search

aspremon / NaiveFeatureSelection

Code for NaiveFeatureSelection, i.e. feature selection in Naive Bayes, see https://arxiv.org/abs/1905.09884
MIT License
9 stars 7 forks source link

Fix import for Scikit learn and other errors #9

Open ThomasJanssoone opened 3 years ago

ThomasJanssoone commented 3 years ago

With the new release of Scikit-learn, NFS will stop working as an import is changed

from sklearn.feature_selection.base import SelectorMixin

should be replaced by 

from sklearn.feature_selection import SelectorMixin

I have created a branch to fix this

I also see some errors in the script DemoDNA.py I added an automatic downloader for the datase, allow NaiveFeatureSelection object to keep a dictionary of results to keep the script up to date, and update the dependence of plotly

Is there a way to do a pull request of these changes ?

arminaskari commented 3 years ago

Hi Thomas,

Sorry for the late reply... You can submit a pull request and then I can approve the changes

ThomasJanssoone commented 3 years ago

I do not have the permission to write in the repository 


remote: Permission to aspremon/NaiveFeatureSelection.git denied to ThomasJanssoone.
fatal: unable to access 'https://github.com/aspremon/NaiveFeatureSelection/': The requested URL returned error: 403

How do you want me to proceed ?