asrob-uc3m / robotDevastation

A new-generation shooter with augmented reality and real robots. You can play online with other users with your PC, moving robots in championships and campaigns: all 24/7!
http://asrob-uc3m.github.io/workgroups/2017-05-28-robot-devastation.html
GNU Lesser General Public License v2.1
9 stars 4 forks source link

C++ code cleanup #102

Closed PeterBowman closed 7 years ago

PeterBowman commented 7 years ago

Resolves #96, see issue description for a list of implemented changes.

PeterBowman commented 7 years ago

Segfault at testInitState w/ gcc, I'll check it later: https://travis-ci.org/asrob-uc3m/robotDevastation/jobs/222596114#L4461.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 81.763% when pulling d7e9a349753420ad4b52bd060ddf45c32165613e on patch-issue96 into a275d1a0646f22c228bd3ba24d7ae1fb402ff2dc on develop.

PeterBowman commented 7 years ago

Segfault at testInitState w/ gcc, I'll check it later: https://travis-ci.org/asrob-uc3m/robotDevastation/jobs/222596114#L4461.

No clue... I'd bet this is caused by some race condition linked to the use of multiple threads. Of course, the error is gone with the latest build.

David-Estevez commented 7 years ago

Great job @PeterBowman !!

Everything is ok, merging PR.