search

assada / laravel-achievements

Laravel 6+ User Achievements system.
https://assada.github.io/laravel-achievements/
MIT License
66 stars 28 forks source link

Migrations | Config Table Names - Incomplete Implementation #4

Closed bayareawebpro closed 4 years ago

bayareawebpro commented 4 years ago

Looks like you forgot to update the dropTable names to use the config:

https://github.com/assada/laravel-achievements/blob/master/src/Migrations/0000_00_00_000000_create_achievements_tables.php#L67

Schema::dropIfExists($this->achievement_progress);
Schema::dropIfExists($this->achievement_details);

Also Here:

https://github.com/assada/laravel-achievements/blob/master/src/Migrations/0000_00_00_000000_create_achievements_tables.php#L55

$table->foreign('achievement_id')->references('id')->on($this->achievement_details);
assada commented 4 years ago

Thnx! Fixed https://github.com/assada/laravel-achievements/commit/6c0d8412e1a22ec3cc3bb73c7e9c9ebbeb7798dd