search

assaf / node-passbook

iOS Passbook for the Node hacker
MIT License
280 stars 73 forks source link

Fixed loading of images via url #10

Closed Joezo closed 9 years ago

Joezo commented 11 years ago

The problem: Using urls for the icon and logo images will fail. It will load at all of them but one. It finalises the manifest by calling doneWithImages() before the file has been loaded into the manifest.

The fix: listen for the file close event and then call doneWithImages if needs be. The sha hash generation takes time which caused the problem, this fixes that.

Also I added passkey.pem as this is needed to sign the pass now. I also removed the signature check test as it will only ever pass on osx which is not ideal.

All tests pass.

assaf commented 11 years ago

Can't merge this, you removed the only test we have that verifies the signature!

Joezo commented 11 years ago

I can add it back in but I can't verify myself whether it passes or not. Other than I know it's working it's generating valid pass files.

Joezo commented 11 years ago

Added it back in, hopefully good to merge now! Good work though!