search

assaf / node-passbook

iOS Passbook for the Node hacker
MIT License
280 stars 73 forks source link

Images corrupted in Node.js 0.12 #27

Open loris opened 9 years ago

loris commented 9 years ago

When using node-passbook to generate and sign a pkpass file, the latest image being added is always corrupted (see below). This issue appeared when upgrading to Node.js 0.12. Downgrading to 0.10.x solve the problem. Any idea?

AndrewBarba commented 9 years ago

I am seeing similar results on io.js 1.2.0 and Node 0.12

AndrewBarba commented 9 years ago

This should be fixed in version 2.1

loris commented 9 years ago

Great news, will test this ASAP, could you explain what the bug/fix was about? Only change I found was the removal of an event listener : https://github.com/assaf/node-passbook/commit/6fcf949979289b7cdd58c8a4692ce69bf6be2aab#diff-9719ab3f52c425bd2475836dc44bc0c8L396

AndrewBarba commented 9 years ago

To be perfectly honestly with you, I don't know if my explanation is the real reason it is fixed but I tried removing it because the whole point of a writable-stream is for the write method to be called with a chunk of data. That event listener was either double calling the write method or it was messing up the stream with that source.resume()