assaf / node-replay

When API testing slows you down: record and replay HTTP responses like a boss
http://documentup.com/assaf/node-replay
MIT License
522 stars 107 forks source link

request occasionally fires multiple end events #120

Open justincy opened 8 years ago

justincy commented 8 years ago

When using request the end events are sometimes fired multiple times. This is because request includes a fix for a bug in node core. request will fire an end when it see a close event if it hasn't yet seen an end event. Sometimes request is receiving the close event from node-replay first which causes it to fire an end event and then request receives the end event from node-replay and fires another end event.

A quick fix is disabling these lines of code but I don't know if that would have any unintended consequences.

I believe it only occurs on some requests because it's a race condition.