Bug fixes - Githubissues

assaf / node-replay

When API testing slows you down: record and replay HTTP responses like a boss

http://documentup.com/assaf/node-replay

MIT License

522 stars 107 forks source link

Bug fixes #152

Closed fed135 closed 5 years ago

fed135 commented 6 years ago

Fixed Superagent compatibility (fixes path.indexOf is not a function error)
Removed gulp-notify, which is not working on some Linux distros like Alpine
Resolutions makes sure that the proper natives module lib is loaded for more recent node versions

Sushmeet commented 5 years ago

@assaf Would appreciate greatly if you could give this PR a review. We are big fans of the node-replay and are building a new project which will use Node 10. This PR will help us and a lot of other people who might be moving towards Node 10 and onwards.

assaf commented 5 years ago

Which of these changes are necessary for Node 10?

fed135 commented 5 years ago

The resolution config in the package.json and the path property in the proxy.

No sure if that is still the case, will have to re run those tests

fed135 commented 5 years ago

It looks like this is no longer required on our side. I'll close this now, feel free to reach out if you are interested in some aspects of the PR.