search

assaf / node-replay

When API testing slows you down: record and replay HTTP responses like a boss
http://documentup.com/assaf/node-replay
MIT License
522 stars 107 forks source link

[Bug] Makes real network requests in Node 10 #155

Closed aaronjameslang closed 5 years ago

aaronjameslang commented 6 years ago

Works fine in v6/v8: https://travis-ci.org/aaronjameslang/survey-monkey-streams/jobs/387636141

Very slow in v10: https://travis-ci.org/aaronjameslang/survey-monkey-streams/jobs/387636140

Running these tests offline locally gives {"errno":"ENOTFOUND","code":"ENOTFOUND","syscall":"getaddrinfo"}

Don't have time to fix this rn, hopefully someone else can pick it up, or at least confirm. Thanks for the awesome module!

aaronjameslang commented 6 years ago

Just did the same thing in a different module and spent two days blaming it on parcel/jest/typescript/myself 🤦‍♂️

node v10.3.0

Not as simple as the version though https://travis-ci.org/aaronjameslang/node-replay

tamlyn commented 5 years ago

Node 10 is now LTS. Does anyone have time to dig deeper and resolve this issue? See also #141, #157.

aaronjameslang commented 5 years ago

Not really a fix, but https://github.com/Netflix/pollyjs seems to solve the same problems. I've not had a chance to switch and try it though.

mehdibeldjilali commented 5 years ago

Please, Does anyone have time to resolve this issue please 😄

djanowski commented 5 years ago

2.4.0 fixes this issue. Thanks for reporting.

jugglinmike commented 5 years ago

This is a very useful module, so the fix is much appreciated. Thank you!