search

assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Rails 5 before/after_filter deprecation warnings #314

Closed terracatta closed 7 years ago

terracatta commented 7 years ago

The master branch of vanity will throw the following deprecation warnings on a Rails 5.x application.

DEPRECATION WARNING: around_filter is deprecated and will be removed in Rails 5.1. Use around_action instead. (called from use_vanity at /Users/<snip>/.rvm/gems/ruby-2.3.1/bundler/gems/vanity-6d55564d417b/lib/vanity/frameworks/rails.rb:47)
DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from use_vanity at /Users/<snip>/.rvm/gems/ruby-2.3.1/bundler/gems/vanity-6d55564d417b/lib/vanity/frameworks/rails.rb:48)
DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from use_vanity at /Users/<snip>/.rvm/gems/ruby-2.3.1/bundler/gems/vanity-6d55564d417b/lib/vanity/frameworks/rails.rb:49)
DEPRECATION WARNING: after_filter is deprecated and will be removed in Rails 5.1. Use after_action instead. (called from use_vanity at /Users/<snip>/.rvm/gems/ruby-2.3.1/bundler/gems/vanity-6d55564d417b/lib/vanity/frameworks/rails.rb:50)

Offending lines are here: https://github.com/assaf/vanity/blob/master/lib/vanity/frameworks/rails.rb#L47-L50

phillbaker commented 7 years ago

Fixed by #326.