search

assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Change *_filter to *_action to remove dep warning #315

Closed terracatta closed 7 years ago

terracatta commented 7 years ago

This change renames the before_filter and after_filter calls to be Rails 5 compatible to remove deprecation warnings.

Resolves Issue #314

phillbaker commented 7 years ago

Looks like this breaks compatibility with rails3. What do you think about a check for if responds_to?(:before_action)?

terracatta commented 7 years ago

@phillbaker commit f9d6421 should fix it. Sorry for making the CI build a bad commit. Let me know if you need me to squash.

Aethelflaed commented 7 years ago

👍 we need this.

phillbaker commented 7 years ago

Fixed by #326.