assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Multi metric support for ab tests (using redis) #318

Closed sdhull closed 2 years ago

sdhull commented 7 years ago

This is really a WIP PR because I only implemented the support for redis adapter. I have neither the time nor the inclination to get this working for mongo & AR, though I was careful not to break those adapters.

You can feel free to drag this across the finish line, as I am allowing edits from vanity maintainers. This also may be useful for others who are struggling with similar problems (eg, tracking funnel conversion with experiments).

Improvements:

phillbaker commented 7 years ago

@sdhull thanks for the PR, it'll take me a couple of days to review, but this is awesome! It's good work toward a solution for https://github.com/assaf/vanity/issues/230.

bensheldon commented 2 years ago

Closing this for inactivity. Please comment/reopen if you'd like to pick it back up.