Use send to change _filter/_action callbacks for Rails 5

assaf / vanity

Experiment Driven Development for Ruby

http://vanity.labnotes.org

MIT License

1.55k stars 269 forks source link

Closed bensheldon closed 7 years ago

bensheldon commented 7 years ago

This change renames the before_filter and after_filter calls to be Rails 5 compatible. It is based on the feedback in PR #315.

I've been running this patch in production and it's working well.

Sorry to open a duplicative PR, but I didn't hear back from @terracatta when I opened a PR against their PR: https://github.com/terracatta/vanity/pull/1

Thank you for this awesome gem.

phillbaker commented 7 years ago

Thanks @bensheldon! Can you squash the first three commits into just one? Otherwise, looks good to me.

bensheldon commented 7 years ago

@phillbaker I squashed down to a single commit.