search

assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Support for redis 4 #334

Closed askehansen closed 6 years ago

askehansen commented 6 years ago

Redis 4 no longer supports redis["key"] and redis["key"] = "val"

askehansen commented 6 years ago

Will do :)

phillbaker commented 6 years ago

@askehansen just checking in, still able to work on this?

askehansen commented 6 years ago

@phillbaker right, i just forgot all about it :)

phillbaker commented 6 years ago

Another option to updating the mocks would be to delete the mocks and use https://github.com/brigade/mock_redis.

laddng commented 6 years ago

@askehansen was wondering if this was still active?

askehansen commented 6 years ago

@laddng when i ran the tests it failed with an exception and i didn't look into it

phillbaker commented 6 years ago

Sorry for the slow turn around here - hoping to update the tests this weekend and then will cherrypick this commit.

phillbaker commented 6 years ago

Cherry-picked in f06d90b5bddb2c91df44a79d6c3070c57080e7da. Thanks!