search

assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Rails 5 Support #348

Closed tansaku closed 5 years ago

tansaku commented 6 years ago

Working with Rails 5 we get the following issue:

Directly inheriting from ActiveRecord::Migration is not supported
phillbaker commented 6 years ago

Is this a deprecation warning or an error?

This would be good to fix however.

On Tue, Aug 28, 2018 at 12:59 PM Sam Joseph notifications@github.com wrote:

Working with Rails 5 we get the following issue:

Directly inheriting from ActiveRecord::Migration is not supported

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/assaf/vanity/issues/348, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFxKdV_MDK1wBKA5WifnTJGg5ItTmIpks5uVXbwgaJpZM4WQBUt .

tansaku commented 6 years ago

hi @phillbaker it was a blocking error I think

phillbaker commented 5 years ago

Looks like https://github.com/RolifyCommunity/rolify/pull/463/files is a good approach.

phillbaker commented 5 years ago

Fixed in https://github.com/assaf/vanity/commit/b20d7336c80a75c48abef12caff2526d46554f56