Upgrade yajl-ruby so that it can be compiled with ruby 2.4

assaf / vanity

Experiment Driven Development for Ruby

http://vanity.labnotes.org

MIT License

1.55k stars 269 forks source link

Upgrade yajl-ruby so that it can be compiled with ruby 2.4 #354

Closed JIAZHEN closed 5 years ago

JIAZHEN commented 5 years ago

Fix the bundle install error as yajl-ruby 1.2.1 not compatible with ruby 2.4

current directory: /Users/jiazhen/Documents/vanity/.bundle/gems/yajl-ruby-1.2.1/ext/yajl
make "DESTDIR="
compiling yajl.c
compiling yajl_alloc.c
compiling yajl_buf.c
compiling yajl_encode.c
compiling yajl_ext.c
yajl_ext.c:881:22: error: use of undeclared identifier 'rb_cFixnum'
    rb_define_method(rb_cFixnum, "to_json", rb_yajl_json_ext_fixnum_to_json, -1);

phillbaker commented 5 years ago

Thanks, had to kick the build on travis, will merge when green.