search

assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Clean up test output #357

Closed urbanautomaton closed 5 years ago

urbanautomaton commented 5 years ago

While working on #356 I noticed quite a lot of noise in the build output; this PR is an attempt to clean it up so it's easier to see errors. Individual changes are explained in the commit messages.

I hope this is mostly uncontroversial; the one change I could see opinions differing on is the change to the dummy app's routes, where a Rails deprecation means they're now a bit more verbose. I don't think there's a way around this though if we're to avoid the deprecation (and, in Rails 5.2, complete removal).

urbanautomaton commented 5 years ago

Thanks for the merge! ❤️